This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path.
- From: Pedro Alves <palves at redhat dot com>
- To: Muhammad Bilal <mbilal at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 29 Jul 2013 15:20:10 +0100
- Subject: Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path.
- References: <97B73E257CC18646B0B5D3DD77DCBDD15DA063 at EU-MBX-02 dot mgc dot mentorg dot com> <97B73E257CC18646B0B5D3DD77DCBDD15DA08C at EU-MBX-02 dot mgc dot mentorg dot com> <51F27050 dot 6060409 at redhat dot com> <51F607C7 dot 7020108 at codesourcery dot com>
Hello,
On 07/29/2013 07:12 AM, Muhammad Bilal wrote:
> 2013-07-29 Muhammad Bilal <mbilal@codesorcery.com>
>
> PR gdb/15715
> * top.c: include "filenames.h"
> (set_history_filename):New function.
Space after ':'.
> static void
> +set_history_filename (char *args, int from_tty, struct cmd_list_element *c)
> +{
> + /*We include the current directory so that if the user changes
> + directories the file written will be the same as the one
> + that was read. */
Formatting still not right. Add a space after '/*', and then reindent.
Also, there's trailing whitespace in the first two lines that should not
be there. The correct format is:
/* We include the current directory so that if the user changes
directories the file written will be the same as the one that
was read. */
> + if (!IS_ABSOLUTE_PATH (history_filename))
> + history_filename = reconcat (history_filename, current_directory, "/",
> + history_filename, (char *) NULL);
> +}
Thanks,
--
Pedro Alves