This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH 0/3] Test mingw32 GDB in cygwin


  Hi all,

  while I find that this patch series is really a big improvement
towards getting usable results for Windows OS native GDB,
I must say that I do not like at all the name of the new
command line option.

  Indeed, I tested your previous patches on a current trunk CVS
source compiled on msys system configured as i686-pc-mingw32.
  I am using an old dejagnu port for msys
which basically suffers the problems a you describe for mingw32 GDB
on a cygwin tty.
  
  But to me it seems rather odd that we should use --cygwin-tty
option on an msys terminal.
  Maybe --windows-so-tty would be more appropriate?

Pierre Muller  

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Yao Qi
> Envoyé : jeudi 25 juillet 2013 07:09
> À : gdb-patches@sourceware.org
> Objet : [PATCH 0/3] Test mingw32 GDB in cygwin
> 
> Hi,
> This patch series try to fix the problems we've seen on running
> mingw32 native for testing in cygwin tty.  Patch 2/3 unbuffer the
> stdout and stderr, so that dejagnu/expect can match the output in
> the right order.  Likewise, patch 3/3 sets stdin/stdout/stderr into
> binary mode, so that dejagnu/expects can match the eol correctly
> too.
> 
> Patch 2/3 and 3/3 was posted last week,
> 
>   http://sourceware.org/ml/gdb-patches/2013-07/msg00481.html
>   http://sourceware.org/ml/gdb-patches/2013-07/msg00358.html
> 
> and one review comment is that these changes affect the behavior of
> mingw32 GDB as a typical native win32 application.  In order to
> remove this side effect, a new option '--cyginw-tty' is added in
> patch 1/3, which tells GDB that it is running in Cygwin TTY.
> 
> The whole series are tested on native mingw32 GDB running in cygwin.
> Test results are improved dramatically.
> 
> *** BLURB HERE ***
> 
> Yao Qi (3):
>   New option --cygwin-tty.
>   Unbuffer stdout and stderr on windows
>   native mingw32 gdb, eol format
> 
>  gdb/NEWS                         |    4 +++
>  gdb/defs.h                       |    4 +++
>  gdb/main.c                       |   54
> ++++++++++++++++++++++++++++++++++++++
>  gdb/testsuite/gdb.base/dbx.exp   |    3 +-
>  gdb/testsuite/lib/gdb.exp        |   35 +++++++++++++++++++++++-
>  gdb/testsuite/lib/mi-support.exp |    3 +-
>  6 files changed, 99 insertions(+), 4 deletions(-)
> 
> --
> 1.7.7.6



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]