This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA, doc RFA] set print frame-arguments-raw on|off
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches <gdb-patches at sourceware dot org>, palves at redhat dot com
- Date: Wed, 17 Jul 2013 13:50:01 -0600
- Subject: Re: [RFA, doc RFA] set print frame-arguments-raw on|off
- References: <yjt2sj00sfz5 dot fsf at ruffy dot mtv dot corp dot google dot com> <20943 dot 41509 dot 270378 dot 842286 at ruffy dot mtv dot corp dot google dot com> <83ip0vd4sf dot fsf at gnu dot org> <CADPb22T-FpXebU8pkvEHPsY=9E+0m8PzXwbCw2=Adbtoxm=DyQ at mail dot gmail dot com> <20966 dot 61429 dot 746380 dot 387990 at ruffy dot mtv dot corp dot google dot com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> Here is a revised version of "set print frame-arguments-raw".
Doug> It renames the option to "set print raw frame-arguments" to allow for
Doug> other things that we might want to control raw printing of.
Looks good to me.
It might be nice to allow this as an argument to "bt" as well, for
one-off uses.
Doug> There's one thing I'm not sure of:
Doug> which one of gdbcmd.h vs cli/cli-cmds.h to use?
Doug> They each declare the set/show list globals.
Doug> gdbcmd.h has a comment saying it's deprecated.
Doug> However, it defines maintenance_{set,show}_cmdlist whereas cli-cmds.h
Doug> does not (which I agree with to the extent that if I were to try to clean
Doug> this area up I would make a few changes, e.g., better separation of gdb
Doug> and cli-as-module, but they're beyond the scope of this patch).
I think cli/cli-cmds.h is preferable for "pure CLI" things.
IMNSHO any public object ought to have a single declaration in a single
header file. Any kind of duplication here is bad.
Tom