This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Add options to skip unavailable locals


> From: Yao Qi <yao@codesourcery.com>
> Date: Wed, 3 Jul 2013 09:48:26 +0800
> 
> This is the patch to add new option '--skip-unavailable' to MI
> commands '-stack-list-{locals, arguments, variables}'.  This patch
> extends list_args_or_locals to add a new parameter 'skip_unavailable',
> and don't list locals or arguments if values are unavailable and
> 'skip_unavailable' is true.

Thanks.

> +  ** The commands -stack-list-locals, -stack-list-arguments and
> +     -stack-list-variables now accept an optional "--skip-unavailable"
> +     option.  When used, only the available locals or arguments are
> +     displayed.

"optional option" doesn't sound right.  I think dropping the
"optional" part is all you need.

> +If the @code{--skip-unavailable} option is specified, arguments that
> +have not been available are not listed.  Partially available objects
   ^^^^^^^^^^^^^^^^^^^^^^^
"are not available".

And why "objects" instead of "arguments"?

> +If the @code{--skip-unavailable} option is specified, local variables
> +that have not been available are not listed.  Partially available
> +objects are still displayed, however.

Likewise, on both accounts.  There are other places with the same
problems.

> +If the @code{--skip-unavailable} option is specified, then, local
                                                         ^^^^^
This "then" and the comma after it should be deleted.

OK with those changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]