Re: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes

[Hui Zhu <teawater at gmail dot com>]

On Tue, Jul 2, 2013 at 10:44 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 07/02/2013 09:30 PM, Hui Zhu wrote:
>>
>> --- a/gdb/mi/mi-cmd-break.c
>> +++ b/gdb/mi/mi-cmd-break.c
>> @@ -128,6 +128,9 @@ mi_argv_to_format (char **argv, int argc
>>         case '\v':
>>           obstack_grow (&obstack, "\\v", 2);
>>           break;
>> +       case '"':
>> +         obstack_grow (&obstack, "\\\"", 2);
>> +         break;
>>         default:
>>           if (isprint (argv[0][i]))
>>             obstack_grow (&obstack, argv[0] + i, 1);
>
>
> IWBN to add a test case to show that GDB handles double quotes correctly
> after this fix.

Hi Yao,

Thanks for your remind.

Post a new patch about test this issue.

Best,
Hui

>
> --
> Yao (éå)

2013-07-03  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15692
	mi/mi-cmd-break.c (mi_argv_to_format): Handle double quotes.

2013-07-03  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15692
	gdb.mi/mi-dprintf.exp: Add double quotes test.

Attachment: dprintf-mi-handle-quotes.txt
Description: Text document

Attachment: dprintf-mi-handle-quotes-test.txt
Description: Text document