This is the mail archive of the
mailing list for the GDB project.
Re: [3/3] [PATCH] value_optimized_out and value_fetch_lazy
- From: "Andrew Burgess" <aburgess at broadcom dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: "Pedro Alves" <palves at redhat dot com>
- Date: Mon, 1 Jul 2013 19:06:34 +0100
- Subject: Re: [3/3] [PATCH] value_optimized_out and value_fetch_lazy
- References: <51B5A95F dot 7090400 at broadcom dot com> <51C1D347 dot 3020906 at redhat dot com>
On 19/06/2013 4:50 PM, Pedro Alves wrote:
> On 06/10/2013 11:24 AM, Andrew Burgess wrote:
>> I ran into an issue with gdb that appears to be caused by an incorrect
>> use of value_optimized_out.
> I'm finding the patch a bit hard to read though. Could you
> split it up?
This tiny patch notices that when we mark a value as optimized out
we can also mark the value as no longer lazy.
This patch is not required, but felt like a good thing to me, not
sure if everyone will agree though.
Should I apply?
2013-07-01 Andrew Burgess <email@example.com>
* value.c (set_value_optimized_out): A value that is optimized out
is no longer lazy.
diff --git a/gdb/value.c b/gdb/value.c
index 8547590..61fd4a1 100644
@@ -1061,6 +1061,8 @@ void
set_value_optimized_out (struct value *value, int val)
value->optimized_out = val;
+ if (val)
+ set_value_lazy (value, 0);