This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/7] gdbserver, common: conditionally include the unistd.h
- From: Pedro Alves <palves at redhat dot com>
- To: Mircea Gherzan <mircea dot gherzan at intel dot com>
- Cc: tromey at redhat dot com, jan dot kratochvil at redhat dot com, gdb-patches at sourceware dot org
- Date: Thu, 27 Jun 2013 19:58:58 +0100
- Subject: Re: [PATCH 1/7] gdbserver, common: conditionally include the unistd.h
- References: <1372322622-3216-1-git-send-email-mircea dot gherzan at intel dot com> <1372322622-3216-2-git-send-email-mircea dot gherzan at intel dot com> <51CC22C2 dot 2020906 at redhat dot com>
On 06/27/2013 12:32 PM, Pedro Alves wrote:
> On 06/27/2013 09:43 AM, Mircea Gherzan wrote:
>> 2013-06-25 Mircea Gherzan <mircea.gherzan@intel.com>
>>
>> * common/agent.c: Conditionally include unistd.h.
>>
>> gdbserver/
>> * hostio.c: Conditionally include unistd.h and define PATH_MAX
>> if unistd.h is not available.
>> * tracepoint.h: Conditionally include unistd.h.
>
> Hmm, I've discussed this PATH_MAX issue before.
> I think we should pull in the unistd and pathmax modules from
> gnulib. In hostio.c, we should cap the max path len to the max
> of PATH_MAX (if defined, it won't on the Hurd), and the packet buffer
> size. Let me post a series for that.
Posted at:
http://sourceware.org/ml/gdb-patches/2013-06/msg00838.html
Could you give it a try?
--
Pedro Alves