This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] gdb/testsuite/gdb.dwarf2: Replaces @ with % sign to allow tests stay compatible with both arm and x86 assembly


ARM assembler recognise @ symbol as a comment marker and therefore is
unable to assemble some of gdb.dwarf2 testsuite tests. This patch
replaces all occurrences of @ symbol with % sign to allow tests stay
compatible with both arm and x86 assembly. This patch has been tested
on x86_64 and armv7 targets.

gdb/testsuite/ChangeLog:

2013-06-10  Omair Javaid  <Omair.Javaid@linaro.org>

        * gdb.dwarf2/fission-reread.S: Replace @ sign with % sign to remove
        assembler errors on arm.
        * gdb.dwarf2/mac-fileno.S: Likewise
        * gdb.dwarf2/member-ptr-forwardref.S: Likewise
        * gdb.dwarf2/pr13961.S: Likewise

Index: gdb/testsuite/gdb.dwarf2/fission-reread.S
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/fission-reread.S,v
retrieving revision 1.7
diff -u -p -r1.7 fission-reread.S
--- gdb/testsuite/gdb.dwarf2/fission-reread.S	1 Jan 2013 06:41:22 -0000	1.7
+++ gdb/testsuite/gdb.dwarf2/fission-reread.S	10 Jun 2013 00:51:30 -0000
@@ -43,7 +43,7 @@
 	.globl	baz
 	.data	/* Previously this used .bss, but it's not portable.  */
 	.align 4
-	.type	baz, @object
+	.type	baz, %object
 	.size	baz, 4
 baz:
 	.zero	4
@@ -51,7 +51,7 @@ baz:
 	.text
 .Ltext0:
 	.globl	main
-	.type	main, @function
+	.type	main, %function
 main:
 .LFB0:
 	.file 1 "fission-reread.cc"
Index: gdb/testsuite/gdb.dwarf2/mac-fileno.S
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/mac-fileno.S,v
retrieving revision 1.11
diff -u -p -r1.11 mac-fileno.S
--- gdb/testsuite/gdb.dwarf2/mac-fileno.S	1 Jan 2013 06:41:22 -0000	1.11
+++ gdb/testsuite/gdb.dwarf2/mac-fileno.S	10 Jun 2013 00:51:31 -0000
@@ -200,7 +200,7 @@ func_cu1:

 .Lline1_end:

-	.section	.debug_macinfo,"",@progbits
+	.section	.debug_macinfo,"",%progbits
 .Ldebug_macinfo0:
 	.byte	0x3	/* Start new file */
 	.uleb128 0x0	/* Included from line number 0 */
Index: gdb/testsuite/gdb.dwarf2/member-ptr-forwardref.S
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/member-ptr-forwardref.S,v
retrieving revision 1.6
diff -u -p -r1.6 member-ptr-forwardref.S
--- gdb/testsuite/gdb.dwarf2/member-ptr-forwardref.S	1 Jan 2013
06:41:22 -0000	1.6
+++ gdb/testsuite/gdb.dwarf2/member-ptr-forwardref.S	10 Jun 2013 00:51:31 -0000
@@ -31,24 +31,24 @@
      } c;  */

 	.file	"member-ptr-forwardref.cc"
-	.section	.debug_abbrev,"",@progbits
+	.section	.debug_abbrev,"",%progbits
 .Ldebug_abbrev0:
-	.section	.debug_info,"",@progbits
+	.section	.debug_info,"",%progbits
 .Ldebug_info0:
-	.section	.debug_line,"",@progbits
+	.section	.debug_line,"",%progbits
 .Ldebug_line0:
 	.text
 .Ltext0:
 .globl fp
 	.data
 	.align 4
-	.type	fp, @object
+	.type	fp, %object
 	.size	fp, 8
 fp:
 	.zero	8
 .globl c
 	.align 4
-	.type	c, @object
+	.type	c, %object
 	.size	c, 8
 c:
 	.zero	8
@@ -290,7 +290,7 @@ c:
 	.byte	0x0
 	.byte	0x0
 	.byte	0x0
-	.section	.debug_pubnames,"",@progbits
+	.section	.debug_pubnames,"",%progbits
 	.4byte	0x1b	/* Length of Public Names Info */
 	.2byte	0x2	/* DWARF Version */
 	.4byte	.Ldebug_info0	/* Offset of Compilation Unit Info */
@@ -300,7 +300,7 @@ c:
 	.4byte	0x9c	/* DIE offset */
 	.ascii "c\0"	/* external name */
 	.4byte	0x0
-	.section	.debug_pubtypes,"",@progbits
+	.section	.debug_pubtypes,"",%progbits
 	.4byte	0x1d	/* Length of Public Type Names Info */
 	.2byte	0x2	/* DWARF Version */
 	.4byte	.Ldebug_info0	/* Offset of Compilation Unit Info */
@@ -310,7 +310,7 @@ c:
 	.4byte	0x6e	/* DIE offset */
 	.ascii "C\0"	/* external name */
 	.4byte	0x0
-	.section	.debug_str,"MS",@progbits,1
+	.section	.debug_str,"MS",%progbits,1
 .LASF5:
 	.string	"fp_t"
 .LASF2:
@@ -324,4 +324,4 @@ c:
 .LASF1:
 	.string	"__delta"
 	.ident	"GCC: (GNU) 4.4.2 20091222 (Red Hat 4.4.2-20)"
-	.section	.note.GNU-stack,"",@progbits
+	.section	.note.GNU-stack,"",%progbits
Index: gdb/testsuite/gdb.dwarf2/pr13961.S
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/pr13961.S,v
retrieving revision 1.4
diff -u -p -r1.4 pr13961.S
--- gdb/testsuite/gdb.dwarf2/pr13961.S	1 Jan 2013 06:41:22 -0000	1.4
+++ gdb/testsuite/gdb.dwarf2/pr13961.S	10 Jun 2013 00:51:31 -0000
@@ -42,7 +42,7 @@
 	.globl	baz
 	.data	/* Previously this used .bss, but it's not portable.  */
 	.align 4
-	.type	baz, @object
+	.type	baz, %object
 	.size	baz, 4
 baz:
 #if 0
@@ -56,7 +56,7 @@ baz:
 	.text
 .Ltext0:
 	.globl	main
-	.type	main, @function
+	.type	main, %function
 main:
 .LFB0:
 	.4byte 0
@@ -64,7 +64,7 @@ main:
 	.size	main, .-main
 .Letext0:

-	.section	.debug_types,"",@progbits
+	.section	.debug_types,"",%progbits
 .Ldebug_types0:
 	.4byte	.Ltu_end - .Ltu_start	/* Length of Compilation Unit Info */
 .Ltu_start:
@@ -121,7 +121,7 @@ main:

 .Ltu_end:

-	.section	.debug_info,"",@progbits
+	.section	.debug_info,"",%progbits
 .Ldebug_info0:
 	.4byte	.Lcu_end - .Lcu_start	/* Length of Compilation Unit Info */
 .Lcu_start:
@@ -205,7 +205,7 @@ main:

 .Lcu_end:

-	.section	.debug_abbrev,"",@progbits
+	.section	.debug_abbrev,"",%progbits
 .Ldebug_abbrev0:
 	.uleb128 0x1	/* (abbrev code) */
 	.uleb128 0x41	/* (TAG: DW_TAG_type_unit) */
@@ -333,7 +333,7 @@ main:

 	.byte	0

-	.section	.debug_aranges,"",@progbits
+	.section	.debug_aranges,"",%progbits
 	.4byte	0x1c	/* Length of Address Ranges Info */
 	.2byte	0x2	/* DWARF Version */
 	.4byte	.Ldebug_info0	/* Offset of Compilation Unit Info */
@@ -346,10 +346,10 @@ main:
 	.4byte	0
 	.4byte	0

-	.section	.debug_line,"",@progbits
+	.section	.debug_line,"",%progbits
 .Ldebug_line0:

-	.section	.debug_str,"MS",@progbits,1
+	.section	.debug_str,"MS",%progbits,1
 .LASF0:
 	.string	"GNU C++ 4.6.3 20120306"
 .LASF2:


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]