This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] testsuite/gdb.base: Make skip test not rely on undefined behaviour.
- From: Will Newton <will dot newton at linaro dot org>
- To: gdb-patches at sourceware dot org
- Cc: patches at linaro dot org
- Date: Fri, 07 Jun 2013 19:41:21 +0100
- Subject: [PATCH] testsuite/gdb.base: Make skip test not rely on undefined behaviour.
The skip test currently relies on the order of evaluation of
arguments which is not defined. Use an arithmetic expression
where order is defined instead.
gdb/testsuite/ChangeLog:
2013-06-07 Will Newton <will.newton@linaro.org>
* gdb.base/skip.c: Add results of foo() and bar() before
passing to baz().
* gdb.base/skip.c: baz() now takes one argument instead of
two.
---
gdb/testsuite/gdb.base/skip.c | 4 ++--
gdb/testsuite/gdb.base/skip1.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/testsuite/gdb.base/skip.c b/gdb/testsuite/gdb.base/skip.c
index 565ba93..1281d17 100644
--- a/gdb/testsuite/gdb.base/skip.c
+++ b/gdb/testsuite/gdb.base/skip.c
@@ -1,10 +1,10 @@
int foo();
int bar();
-int baz(int, int);
+int baz(int);
int main()
{
- return baz(foo(), bar());
+ return baz(bar() + foo());
}
int foo()
diff --git a/gdb/testsuite/gdb.base/skip1.c b/gdb/testsuite/gdb.base/skip1.c
index 2dab5c3..fe63cd6 100644
--- a/gdb/testsuite/gdb.base/skip1.c
+++ b/gdb/testsuite/gdb.base/skip1.c
@@ -3,7 +3,7 @@ int bar()
return 1;
}
-int baz(int a, int b)
+int baz(int a)
{
- return a + b;
+ return a + 1;
}
--
1.8.1.4