This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Improve symbol lookup performance noted in PR 15519
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, psmith at gnu dot org, gdb-patches at sourceware dot org
- Date: Fri, 31 May 2013 07:42:31 +0400
- Subject: Re: [patch] Improve symbol lookup performance noted in PR 15519
- References: <20903 dot 57436 dot 871210 dot 593441 at ruffy dot mtv dot corp dot google dot com>
> I'll let it sit for a few days in case there are any more comments.
> I'd also like to commit this to the 7.6 branch. Ok Joel?
> [I need to rerun the testsuite in that tree before committing there.]
No problem regarding putting this fix in the 7.6 branch. Just a quick
reminder, JIC, to add a entry in the 7.6 release wiki page (thank you!).
>
> 2013-05-30 Doug Evans <dje@google.com>
> Keith Seitz <keiths@redhat.com>
>
> PR 15519
> * cp-namespace.c (find_symbol_in_baseclass): Call
> cp_lookup_symbol_in_namespace instead of cp_lookup_symbol_namespace.
> Remove call to lookup_symbol_static. Call lookup_static_symbol_aux
> unconditionally. Call check_typedef on base types before accessing
> them.
> (cp_lookup_nested_symbol): Fix comment.
>
> testsuite/
> * gdb.cp/derivation2.cc: New file.
> * gdb.cp/derivation.cc (main): Call foo2.
> * gdb.cp/derivation.exp: Add tests for typedefs in another
> file, and when there's an active block.
--
Joel