This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH v2] Exit code of exited inferiors


Hi,

This is the second version of my patch to add the exit-code in the -list-thread-groups output. New in v2: NEWS file, documentation and a test case. I didn't find any test about -list-thread-groups so I created it.

As far as I know, this does not break any other test.

Changelog:

2013-05-28  Simon Marchi  <simon.marchi@ericsson.com>

    * gdb/NEWS: Announce new exit-code field.
    * gdb/doc/gdb.texinfo: Document new exit-code field.
    * gdb/inferior.c (exit_inferior_1): Remove exit code clear.
    (inferior_appeared): Add exit code clear.
    * gdb/mi/mi-main.c (print_one_inferior): Add printing of the exit code.
    * gdb/testsuite/gdb.mi/mi-list.exp: New file, added test case for
        -list-thread-groups.

Thanks,

Simon


diff --git a/gdb/NEWS b/gdb/NEWS
index a23e8e3..2f745c4 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -76,6 +76,9 @@ show range-stepping

   ** The new command -dprintf-insert sets a dynamic printf breakpoint.

+  ** The -list-thread-groups command outputs an exit-code field for
+     inferiors that have exited.
+
 * New system-wide configuration scripts
   A GDB installation now provides scripts suitable for use as system-wide
   configuration scripts for the following systems:
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index ead00b4..104b3d0 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -34511,6 +34511,11 @@ valid type.
 The target-specific process identifier.  This field is only present
 for thread groups of type @samp{process} and only if the process exists.

+@item exit-code
+The exit code of this thread group when it last exited. This field is
+only present for thread groups of type @samp{process} and only if the
+process is not running.
+
 @item num_children
 The number of children this thread group has.  This field may be
 absent for an available thread group.
diff --git a/gdb/inferior.c b/gdb/inferior.c
index ed6b626..a145780 100644
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -275,8 +275,6 @@ exit_inferior_1 (struct inferior *inftoex, int silent)
       inf->vfork_child = NULL;
     }

-  inf->has_exit_code = 0;
-  inf->exit_code = 0;
   inf->pending_detach = 0;
 }

@@ -322,6 +320,8 @@ void
 inferior_appeared (struct inferior *inf, int pid)
 {
   inf->pid = pid;
+  inf->has_exit_code = 0;
+  inf->exit_code = 0;

   observer_notify_inferior_appeared (inf);
 }
diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index 9428e8c..6ce68ec 100644
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -571,6 +571,9 @@ print_one_inferior (struct inferior *inferior, void *xdata)

       ui_out_field_fmt (uiout, "id", "i%d", inferior->num);
       ui_out_field_string (uiout, "type", "process");
+      if (inferior->has_exit_code)
+    ui_out_field_string (uiout, "exit-code",
+      int_string (inferior->exit_code, 8, 0, 0, 1));
       if (inferior->pid != 0)
     ui_out_field_int (uiout, "pid", inferior->pid);

diff --git a/gdb/testsuite/gdb.mi/mi-list.exp b/gdb/testsuite/gdb.mi/mi-list.exp
new file mode 100644
index 0000000..99e3e91
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/mi-list.exp
@@ -0,0 +1,74 @@
+# Copyright 1999-2013 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Test Machine interface (MI) operations
+#
+# Verify various -list-* commands
+
+
+load_lib mi-support.exp
+set MIFLAGS "-i=mi"
+
+gdb_exit
+if [mi_gdb_start] {
+    continue
+}
+
+standard_testfile "exit-code.c"
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
+    untested mi-list.exp
+    return -1
+}
+
+proc test_list_thread_groups { } {
+    global hex
+    global decimal
+
+    # Check before any run
+ mi_gdb_test "122-list-thread-groups" "122\\^done,groups=\\\[\{id=\"i1\",type=\"process\"\}\]" "test -list-thread-groups 1"
+
+    # Run to main
+    mi_run_to_main
+
+    # Check during the run
+ mi_gdb_test "123-list-thread-groups" "123\\^done,groups=\\\[\{id=\"i1\",type=\"process\",pid=\"$decimal\",executable=\".*\",cores=\\\[\"$decimal\"\]\}\]" "test -list-thread-groups 2"
+
+    # Exit the inferior
+    mi_send_resuming_command "exec-continue" "continuing to exit inferior"
+    mi_expect_stop "exited-normally" "" "" "" "" "" "exiting inferior"
+
+    # Check after the run
+ mi_gdb_test "124-list-thread-groups" "124\\^done,groups=\\\[\{id=\"i1\",type=\"process\",exit-code=\"0\",executable=\".*\"\}\]" "test -list-thread-groups 3"
+
+    # Start the program again to get an other exit code
+    mi_run_to_main 10
+
+    # Check during the second run (exit code should have disappeared)
+ mi_gdb_test "125-list-thread-groups" "125\\^done,groups=\\\[\{id=\"i1\",type=\"process\",pid=\"$decimal\",executable=\".*\",cores=\\\[\"$decimal\"\]\}\]" "test -list-thread-groups 4"
+
+    # Exit the inferior
+    mi_send_resuming_command "exec-continue" "continuing to exit inferior"
+    mi_expect_stop "exited" "" "" "" "" "" "exiting inferior"
+
+    # Check after the second run
+ mi_gdb_test "126-list-thread-groups" "126\\^done,groups=\\\[\{id=\"i1\",type=\"process\",exit-code=\"012\",executable=\".*\"\}\]" "test -list-thread-groups 5"
+}
+
+test_list_thread_groups
+
+
+mi_gdb_exit
+return 0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]