This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Add a select_frame_reason enum parameter to select_frame
- From: Maxime Coste <frrrwww at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 May 2013 15:20:12 +0200
- Subject: Re: [PATCH 1/3] Add a select_frame_reason enum parameter to select_frame
- References: <1367002961-12311-1-git-send-email-frrrwww at gmail dot com> <1367002961-12311-2-git-send-email-frrrwww at gmail dot com> <87r4htxeth dot fsf at fleche dot redhat dot com> <5187E029 dot 8070008 at redhat dot com>
Hello
On Mon, 06 May 2013 17:54:01 +0100, Pedro Alves <palves@redhat.com> wrote:
> IMO, it'd be better to leave select_frame unaware of why it's being
> called, and just add a wrapper for user visible frame selection.
> It feels like different conceptual levels to me. IOW, something like:
>
> void
> select_user_frame (struct frame_info *fi)
> [...]
That seems better to me too, I went the other way because at first I tried
to add checks for frame restoration (there were IMPL_DETAIL_{PUSH,POP}
with a counter checking that only IMPL_DETAIL_* were nested...
I'll prepare a patch using this approach.
> If we limit frame change notifications to user frame changes
> (CLI up/down/frame and MI equivalents), then these issues
> with stops would be non-issues by design...
Yes, this seems more reasonable as well.
Thanks for the review.
Maxime.