This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Thread exit messages on MS-Windows


> Date: Sat, 27 Apr 2013 20:10:40 +0200
> From: Corinna Vinschen <vinschen@redhat.com>
> 
> On Apr 27 12:00, Eli Zaretskii wrote:
> > One minor correction:
> > 
> > > +  else if (print_thread_events && id != main_thread_id)
> > > +    printf_unfiltered (_("[%s exited with code %d]\n"),
> >                                                   ^^
> > This should be %lu, not %d.
> 
> If this code is generic and runs under Cygwin as well, then please make
> that %u, not %lu.  DWORD is a 4 byte value and under 64 bit Cygwin
> (LP64), it's not the same as long, but as int.  Alternatively, add an
> explicit cast to unsigned long to the argument.

Thanks, will do (the former, probably).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]