This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] 3 of 5 - Frame filter CLI/misc code changes.
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 25 Apr 2013 13:39:39 -0600
- Subject: Re: [patch][python] 3 of 5 - Frame filter CLI/misc code changes.
- References: <51753BBA dot 9070502 at redhat dot com>
Phil> * Makefile.in: Add py-framefiler build changes.
Typo in the file name.
It's more usual to list the variables you updated and also the new
rule.
Phil> * data-directory/Makefile.in: Ditto
I don't think "ditto" is correct here.
Phil> + int result = 0;
enum type.
Phil> + int flags = PRINT_LEVEL | PRINT_FRAME_INFO | PRINT_ARGS;
Phil> + enum py_frame_args arg_type;
Phil> if (show_locals)
Phil> + flags |= PRINT_LOCALS;
Blank line between declarations and code here.
Tom