This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] patch for review of PR gdb/10462
- From: Tom Tromey <tromey at redhat dot com>
- To: mbilal <mbilal at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 16 Apr 2013 11:25:35 -0600
- Subject: Re: [patch] patch for review of PR gdb/10462
- References: <516D3B30 dot 6080501 at codesourcery dot com>
>>>>> ">" == mbilal <mbilal@codesourcery.com> writes:
>> please find attached, proposed patch for PR gdb/10462
>> that is, argument must be preceded by space.
>> + if (strlen(*line) != 0 && c->type == set_cmd && **line != ' ' )
Space after 'strlen' and no space before the ')'.
Also, it seems like isspace would be better here.
Finally, this could use a test case.
You can just add one to some relevant .exp file.
Tom