This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration'
- From: Doug Evans <dje at google dot com>
- To: Yao Qi <yao at codesourcery dot com>, Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 15 Apr 2013 11:50:51 -0700
- Subject: Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration'
- References: <1365761475-23845-1-git-send-email-yao at codesourcery dot com>
On Fri, Apr 12, 2013 at 3:11 AM, Yao Qi <yao@codesourcery.com> wrote:
> The recent committed CTF patch introduces a new configure option
> '--with-babeltrace'. This patch is to print the configure choice
> in 'gdb --configuration'. Is it OK?
>
> gdb:
>
> 2013-04-12 Yao Qi <yao@codesourcery.com>
>
> * top.c (print_gdb_configuration): Print configure-time
> parameter on using libbabeltrace or not.
> ---
> gdb/top.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/gdb/top.c b/gdb/top.c
> index 6a402ba..480b67e 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -1242,6 +1242,15 @@ This GDB was configured as follows:\n\
> --without-zlib\n\
> "));
> #endif
> +#if HAVE_LIBBABELTRACE
> + fprintf_filtered (stream, _("\
> + --with-babeltrace\n\
> +"));
> +#else
> + fprintf_filtered (stream, _("\
> + --without-babeltrace\n\
> +"));
> +#endif
> }
Do we care about printing --with-libbabeltrace-prefix?
I don't have a strong preference, but if we're going to go down this
path I think we should.
[An alternative would be to punt on details at this level and instead
record the complete string passed to configure and print that.]