This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 23/26] -Wpointer-sign: ada-lang.c, ada-tasks.c.
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 12 Apr 2013 00:01:44 +0100
- Subject: [PATCH 23/26] -Wpointer-sign: ada-lang.c, ada-tasks.c.
- References: <20130411225847 dot 16791 dot 29283 dot stgit at brno dot lan>
We're reading strings using the target memory access routines, which
work with raw bytes, so we need a couple casts.
gdb/
2013-04-11 Pedro Alves <palves@redhat.com>
* ada-lang.c (print_it_exception): Add cast to gdb_byte *.
* ada-tasks.c (read_fat_string_value): Likewise.
---
gdb/ada-lang.c | 3 ++-
gdb/ada-tasks.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 4d07d4d..fdfc0b4 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -11532,7 +11532,8 @@ print_it_exception (enum exception_catchpoint_kind ex, bpstat bs)
if (addr != 0)
{
- read_memory (addr, exception_name, sizeof (exception_name) - 1);
+ read_memory (addr, (gdb_byte *) exception_name,
+ sizeof (exception_name) - 1);
exception_name [sizeof (exception_name) - 1] = '\0';
}
else
diff --git a/gdb/ada-tasks.c b/gdb/ada-tasks.c
index b0835f6..c5c7491 100644
--- a/gdb/ada-tasks.c
+++ b/gdb/ada-tasks.c
@@ -433,7 +433,7 @@ read_fat_string_value (char *dest, struct value *val, int max_len)
/* Extract LEN characters from the fat string. */
array_val = value_ind (value_field (val, array_fieldno));
- read_memory (value_address (array_val), dest, len);
+ read_memory (value_address (array_val), (gdb_byte *) dest, len);
/* Add the NUL character to close the string. */
dest[len] = '\0';