This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] cleanup: Wunused coff-pe-read
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Aleksandar Ristovski <aristovski at qnx dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 28 Mar 2013 17:29:46 -0700
- Subject: Re: [patch] cleanup: Wunused coff-pe-read
- References: <5109EE44 dot 5020605 at qnx dot com>
> Aleksandar Ristovski <aristovski@qnx.com>
>
> * coff-pe-read.c (add_pe_exported_sym): Remove unused DLL_NAME_LEN.
> (add_pe_forwarded_sym): Remove unused SECTION, DLL_NAME_LEN.
> (read_pe_exported_syms): Remove unused EXPORTIX.
> (pe_text_section_offset): Remove unused OPTHDR_OFS, NUM_ENTRIES,
> EXPORT_RVA, EXPORT_SIZE, EXPPTR, EXP_FUNCBASE, EXPDATA,
> ERVA, NAME_RVAS, ORDINALS, NEXP, ORDBASE, DLL_NAME.
Approved. One nit: all-cap ENTITY_NAME means "the value of entity_name".
You are removing the entities themselves, so their name should not
be capitalized. I missed that in the two other patches I just approved.
--
Joel