Re: [RFA] cleanup: while (isspace) -> skip_spaces{,_const}

[Pedro Alves <palves at redhat dot com>]

On 03/07/2013 05:13 PM, Keith Seitz wrote:
> On 03/07/2013 08:39 AM, Pedro Alves wrote:
> 
>> This now continues forward even if *addr_exp is '\0',
>> while before the patch it  didn't.
> 
> Yes, that's right, it is a subtle change that I missed because...
> 
>> And it seems to be we'll now reach that last error in that
>> case, while we wouldn't before.  Can we trigger that with
>> "info register rip    ", say?
> 
> ...it has no effect.  In execute_command, top.c:461, the command parser strips trailing whitespace.

Thanks, I keep forgetting that.

> I can add a check for *addr_exp == '\0' again, if you'd like.

Fine with me to leave it be.  I was going to suggest a
gdb_assert, but the normal error already catches this,
and we can react then if some caller behaves differently.

-- 
Pedro Alves