This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] remote doesn't add the main thread if we didn't do so already


On 02/26/2013 02:39 PM, Hui Zhu wrote:
> Hi Pedro,
> 
> On Tue, Feb 26, 2013 at 8:08 PM, Pedro Alves <palves@redhat.com> wrote:
>> Hi Hui, Luis,
>>
>> Thanks for the patch.
>>
>> On 02/25/2013 11:01 AM, Hui Zhu wrote:
>>> Hi,
>>>
>>> This is the patch to change function add_current_inferior_and_thread that doesn't add the main thread if we didn't do so already.
>>>
>>
>> I have the mild impression I've seen this change before, but heck
>> if I recall any details, and I may be wrong.  Can you or Luis
>> expand on the background/rationale for this change?
> 
> This patch is part of OSE support that includes some small changes and
> some bigger one.  

Okay, that probably explains why I thought I'd seen it before.

> So my thought is  post the small one first.

That's fine, but being small doesn't mean it shouldn't be explained.
Please share the rationale for the change so we have it recorded in
the public archives.  You should be able to find it in Mentor's
internal archives.  What problem does this solve?  When can this
happen (initial connection, vRun, other?).  Etc.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]