This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Tweak warning output on Linux kernels with broken i386 NX support.
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 19 Feb 2013 18:10:36 +0000
- Subject: [PATCH] Tweak warning output on Linux kernels with broken i386 NX support.
The "you have broken" bit of this text reads to me as if I had broken
it myself somehow. I'd like to eliminate that ambiguity.
I kindly ask in advance to avoid a bikeshed, please. :-) Unless there
are seriously strong objections, this is the version I plan checking
in.
2013-02-19 Pedro Alves <palves@redhat.com>
* common/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Change
warning text.
---
gdb/common/linux-ptrace.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gdb/common/linux-ptrace.c b/gdb/common/linux-ptrace.c
index 886be80..e1001c6 100644
--- a/gdb/common/linux-ptrace.c
+++ b/gdb/common/linux-ptrace.c
@@ -224,8 +224,9 @@ linux_ptrace_test_ret_to_nx (void)
"address %p nor is the return instruction %p!"),
pc, return_address, &linux_ptrace_test_ret_to_nx_instr);
else
- warning (_("Cannot call inferior functions, you have broken "
- "Linux kernel i386 NX (non-executable pages) support!"));
+ warning (_("Cannot call inferior functions on this system - "
+ "Linux kernel with broken i386 NX (non-executable pages) "
+ "support detected!"));
#endif /* defined __i386__ || defined __x86_64__ */
}