This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc 2/8] record-full.c: rename record_ in record_full_.


On Thu, 14 Feb 2013 17:29:06 +0100, markus.t.metzger@intel.com wrote:
> The changelog for this renaming will be huge. Is there a way to abbreviate or
> auto-generate it?

There is a script by Daniel Jacobowitz:
	http://sourceware.org/ml/gdb-patches/2006-10/msg00085.html

But as you may find out it does not work too well.

I have tried right now some tiny fixes to it which I consider for many years
already but I apparently do not have experience with this change yet:

--- bin/fsfchangelog-orig	2013-02-15 09:42:14.836287199 +0100
+++ bin/fsfchangelog	2013-02-15 09:42:17.706281390 +0100
@@ -61,9 +61,9 @@ while (<DFILE>) {
     # The first two patterns work with context diff files (diff -c). The
     # third pattern works with unified diff files (diff -u).
 
-    my $linestart = "[-a-zA-Z0-9_.]+";
+    my $linestart = "[-a-zA-Z0-9_.]+(?: [-a-zA-Z0-9_.]+)*";
     if (/^\*\*\*\*\*\** ($linestart)/
-        || /^[\-\+\!] ($linestart)[ \t]*\(.*/
+        || /^[\-\+\!] ?($linestart)[ \t]*\(.*/
 	|| /^@@ .* @@ ($linestart)/)
       {
 	$fn = $1;

Although IMO automating it too much is not good as the goal is to
unconditionally self-review the patch, not to write the ChangeLog entry.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]