This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] cleanup: remove unused - solib
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Aleksandar Ristovski <aristovski at qnx dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 31 Jan 2013 07:23:07 +0100
- Subject: Re: [patch] cleanup: remove unused - solib
- References: <5109E36E.9000209@qnx.com>
On Thu, 31 Jan 2013 04:22:22 +0100, Aleksandar Ristovski wrote:
> Aleksandar Ristovski <aristovski@qnx.com>
>
> * solib-svr4.c (svr4_keep_data_in_core): Remove unused LMO.
> (svr4_read_so_list): Remove unused LMO.
> * solib-target.c (solib_target_relocate_section_addresses):
> Remove unused
> FLAGS.
This is OK, I expected you consider them pre-approved.
As a nitpick here the variables should be lowercased, as we talk about the
variables and not their values:
http://www.gnu.org/prep/standards/standards.html
The comment on a function is much clearer if you use the argument
names to speak about the argument values. The variable name itself
should be lower case, but write it in upper case when you are speaking
about the value rather than the variable itself. Thus, “the inode
number NODE_NUM” rather than “an inode”.
Thanks,
Jan