This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Remove GNU/Linux ARI rule
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 24 Dec 2012 08:19:26 +0400
- Subject: Re: [RFC] Remove GNU/Linux ARI rule
- References: <000c01cde13b$59774080$0c65c180$@muller@ics-cnrs.unistra.fr>
> 2012-12-23 Pierre Muller <muller@sourceware.org>
>
> * contrib/ari/gdb_ari.sh (GNU/Linux rule): Comment out.
No objection on my end, but let's for sure wait until after the
Holiday season to give everyone a chance to comment.
> Index: contrib/ari/gdb_ari.sh
> ===================================================================
> RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
> retrieving revision 1.6
> diff -u -r1.6 gdb_ari.sh
> --- contrib/ari/gdb_ari.sh 29 Nov 2012 17:23:18 -0000 1.6
> +++ contrib/ari/gdb_ari.sh 23 Dec 2012 18:27:01 -0000
> @@ -257,20 +257,23 @@
>
> # Things in comments
>
> -BEGIN { doc["GNU/Linux"] = "\
> -Do not use `Linux'\'', instead use `Linux kernel'\'' or `GNU/Linux
> system'\'';\
> - comments should clearly differentiate between the two (this test assumes
> that\
> - word `Linux'\'' appears on the same line as the word `GNU'\'' or
> `kernel'\''\
> - or a kernel version"
> - category["GNU/Linux"] = ari_comment
> -}
> -/(^|[^_[:alnum:]])Linux([^_[:alnum:]]|$)/ \
> -&& !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
> -&& !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
> -&& !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
> -&& !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
> - fail("GNU/Linux")
> -}
> +# This rule has been disabled
> +# because it produces more false alarms thaan useful
> +# warnings.
"thaan" -> "than". I'd join the line a bit to get longer and more
balanced lines:
> +# This rule has been disabled because it produces more false alarms
> +# than useful warnings.
... Or just delete the rule altogether.
> +# BEGIN { doc["GNU/Linux"] = "\
> +# Do not use `Linux'\'', instead use `Linux kernel'\'' or `GNU/Linux
> system'\'';\
> +# comments should clearly differentiate between the two (this test assumes
> that\
> +# word `Linux'\'' appears on the same line as the word `GNU'\'' or
> `kernel'\''\
> +# or a kernel version"
> +# category["GNU/Linux"] = ari_comment
> +# }
> +# /(^|[^_[:alnum:]])Linux([^_[:alnum:]]|$)/ \
> +# && !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
> +# && !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
> +# && !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
> +# && !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
> +# fail("GNU/Linux")
> +# }
>
> BEGIN { doc["ARGSUSED"] = "\
> Do not use ARGSUSED, unnecessary"
--
Joel