This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if statement
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 23 Dec 2012 21:29:24 +0200
- Subject: Re: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if statement
- References: <001201cde13f$af3ad4b0$0db07e10$%muller@ics-cnrs.unistra.fr>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Sun, 23 Dec 2012 19:59:49 +0100
>
> Looks almost obvious, but
> as it's the first of that kind,
> I thought I will send it as RFA nonetheless...
>
> Can similar changes be committed as obvious?
> They usually require some formatting changes,
> but generated behavior should not change.
>
>
> Pierre Muller
> as ARI maintainer
>
>
> 2012-12-20 Pierre Muller <muller@sourceware.org>
>
> ARI fixes: Assignment within if rule.
> * cli/cli-cmds.c (shell_escape): Do not set variable value inside
> if statement.
> (edit_command): Likewise.
Since when is that bad C, so much so that we would need to enforce it?