This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix memory leak in windows_xfer_shared_libraries
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 14 Dec 2012 09:45:05 +0000
- Subject: Re: [RFA] Fix memory leak in windows_xfer_shared_libraries
- References: <50c9b7e6.25f2440a.3810.3771SMTPIN_ADDED_BROKEN@mx.google.com> <50CA3784.2030706@redhat.com> <000301cdd9d0$0db345d0$2919d170$@muller@ics-cnrs.unistra.fr>
On 12/14/2012 07:53 AM, Pierre Muller wrote:
>>> I was also wondering if it would not be better to keep the obstack in
>>> between the two calls, but that would probably require some static
>> variable
>>> :(
>>
>> That'd be fine. We actually do that in some cases in gdbserver, like
>> handle_qxfer_threads and handle_qxfer_traceframe_info. It just didn't
>> look like worth it enough to bother when I initially wrote this.
>
> I was wondering if this would become a problem if we later add support for
> multiple inferior
> for windows-nat
I don't think so.
> I vaguely remember that I tried to achieve this a long time ago...
ISTR you had an archer branch for that and other Windows stuff.
>
> Anyhow, the memory leak is gone at least!
Thanks.
--
Pedro Alves