This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] minor dwarf2read.c cleanups
- From: Doug Evans <dje at google dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 03 Dec 2012 14:32:23 -0800
- Subject: [commit] minor dwarf2read.c cleanups
Hi.
fyi, I committed this.
2012-12-03 Doug Evans <dje@google.com>
* dwarf2read.c (struct dwarf2_per_objfile): Clarify comment.
(dw2_find_symbol_file): Delete unused local file_data.
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.714
diff -u -p -u -p -r1.714 dwarf2read.c
--- dwarf2read.c 26 Nov 2012 15:54:29 -0000 1.714
+++ dwarf2read.c 3 Dec 2012 22:29:00 -0000
@@ -257,9 +257,12 @@ struct dwarf2_per_objfile
struct mapped_index *index_table;
/* When using index_table, this keeps track of all quick_file_names entries.
- TUs can share line table entries with CUs or other TUs, and there can be
- a lot more TUs than unique line tables, so we maintain a separate table
- of all line table entries to support the sharing. */
+ TUs typically share line table entries with a CU, so we maintain a
+ separate table of all line table entries to support the sharing.
+ Note that while there can be way more TUs than CUs, we've already
+ sorted all the TUs into "type unit groups", grouped by their
+ DW_AT_stmt_list value. Therefore the only sharing done here is with a
+ CU and its associated TU group if there is one. */
htab_t quick_file_names_table;
/* Set during partial symbol reading, to prevent queueing of full
@@ -3385,7 +3388,6 @@ dw2_find_symbol_file (struct objfile *ob
{
struct dwarf2_per_cu_data *per_cu;
offset_type *vec;
- struct quick_file_names *file_data;
const char *filename;
dw2_setup (objfile);