This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] Fix mi "-var-create" regression
- From: Marc Khouzam <marc dot khouzam at ericsson dot com>
- To: "'lgustavo at codesourcery dot com'" <lgustavo at codesourcery dot com>, "'Tom Tromey'" <tromey at redhat dot com>
- Cc: "'Joel Brobecker'" <brobecker at adacore dot com>, "'gdb-patches at sourceware dot org'" <gdb-patches at sourceware dot org>
- Date: Thu, 15 Nov 2012 16:44:29 +0000
- Subject: RE: [PATCH] Fix mi "-var-create" regression
- References: <5075D4FD.9050900@mentor.com> <20121014171805.GB3050@adacore.com> <507BFF97.2000900@codesourcery.com> <87y5j4ziof.fsf@fleche.redhat.com> <508DB53E.30507@codesourcery.com> <87625rwvcp.fsf@fleche.redhat.com> <50A3EF5D.4060607@codesourcery.com>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Luis Machado
> Sent: Wednesday, November 14, 2012 2:22 PM
> To: Tom Tromey
> Cc: Joel Brobecker; gdb-patches@sourceware.org
> Subject: Re: [PATCH] Fix mi "-var-create" regression
>
> On 10/30/2012 06:36 PM, Tom Tromey wrote:
> >>>>>> "Luis" == Luis Machado<lgustavo@codesourcery.com> writes:
> >
> > Luis> 2012-10-15 Luis Machado<lgustavo@codesourcery.com>
> > Luis> * value.c (value_actual_type): Check for
> TYPE_CODE_STRUCT
> > Luis> target types.
> >
> > Luis> testsuite/
> > Luis> * mi-var-create-rtti.c: New file.
> > Luis> * mi-var-create-rtti.exp: New file.
> >
> > This looks good to me. One tiny nit:
> >
> > Luis> Index: gdb/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp
> > Luis> + return -1;
> >
> > No need for a ";" here.
> >
> > Ok with this change.
> >
> > thanks,
> > Tom
>
> Thanks. I've checked this in now.
Nice!
Is it possible to put this in the 7_5 branch?
Thanks
Marc