This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFA] Remove AC_HEADER_STAT from configure.ac


> >   I tried...
> > Here is the result.
> >   Should we add stat.h to the list of checked headers?
> 
> No need.  gdb_stat.h includes sys/stat.h unconditionally.
> 
> > I didn't find any HAVE_STAT_H occurrence,
> > and thus assumed this was unnecessary.
> 
> > PS: In the regenerated files,
> > I discovered that configure has a strange, apparently unrelated
> > change... Is this normal?
> 
> No.  I just tried regenerating configure in the current
> mainline, with no changes to configure.ac, and configure
> did not change for me.  Be sure to use pristine FSF autoconf 2.64.
> Sounds like the autoconf you used has local mingw patches.
> 
> > 2012-11-15  Pierre Muller  <muller@sourceware.org>
> >
> >         * configure.ac (AC_HEADER_STAT): Remove.
> >         * gdb_stat.h (STAT_MACROS_BROKEN): Remove macro use
> >         and corresponding code.
> >         * configure: Regenerate.
> 
> Otherwise this is fine.  Thanks.
I just manually removed the unwanted change to configure and
committed the rest.

Thanks for the approval,

Pierre



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]