This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: should deprecated_target_gdbarch_select_hack be un-deprecated?


On 11/13/2012 09:17 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Tom> Finally, I wonder whether deprecated_target_gdbarch_select_hack should
> Tom> be un-deprecated.
> [...]
> 
> Pedro> Yes, I think so.  We used to do nasty things with swapping out gdbarch's
> Pedro> fields, which I believe would be the gross "hack" part, but that is gone.
> 
> How about this?
> 
> I think my only real concern is the name I chose.

This is fine with me.  My alternative suggestion would be "set_target_gdbarch",
as "set" is more traditional for a setter, which is what this function ended
up being.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]