This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: handle "MiniDebuginfo" section


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> To avoid the #ifdef HAVE_LZMA, I might even provide two versions of the
Joel> file, one with the real implementation, and one with the phony one, and
Joel> have the configure choose which one to link in. This isn't what we've
Joel> been doing in the past (iconv, python), so to be taken with a grain of
Joel> salt. I think it'll make the code a little easier to navigate, however.

To me this seems like a lot of work for a single function.
And, it doesn't make the code less complicated -- the "#if" is still
there, just in configure and Makefile.in rather than in the C.
I tend to find the C code more readable than those, which is something I
like about the current approach.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]