This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 8/9] class-local typedef substitutions
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 02 Nov 2012 14:52:09 -0600
- Subject: Re: [PATCH 8/9] class-local typedef substitutions
- References: <87vcfphdl8.fsf@fleche.redhat.com> <87sjabrx4g.fsf@fleche.redhat.com> <5091795B.7020506@redhat.com> <87hap9qbqm.fsf@fleche.redhat.com>
>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
Pedro> I'm confused and curious at why such a change would be necessary. I
Pedro> couldn't find it from a quick look over the patch.
Pedro> Can you expand a little? Does this also affect the CLI?
Tom> It has been a while, but I think the difference depends on whether the
Tom> type name is sent through canonicalization or not.
Yes, it is due to C++ name canonicalization.
It may be possible to avoid this in some cases, but I can't think of a
situation where the current approach would make the output worse.
It does affect the CLI in some cases, but I see now that I missed the
'default' case in c_type_print_base. I will update that and see what
happens.
Pedro> Why expect both long and "long int"? Is this compiler / debug format
Pedro> dependent, perhaps?
Tom> I will take another look and figure it out.
I think it is safe to just expect "long".
I'll change the patch.
Tom