This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Add fullname field in disassembly output
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <aburgess at broadcom dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 02 Nov 2012 15:32:22 +0000
- Subject: Re: Add fullname field in disassembly output
- References: <506DB4B8.5030001@broadcom.com> <5085B9D5.80508@broadcom.com> <50913B7F.10707@redhat.com> <5093A785.3060103@broadcom.com>
On 11/02/2012 10:59 AM, Andrew Burgess wrote:
> On 31/10/2012 2:53 PM, Pedro Alves wrote:
>
>>> Ok to commit?
>>
>> Not yet, sorry. This new field needs to be documented in the manual, and mentioned in NEWS.
>
> Sorry, I should have realised I'd need to do these things.
>
> Latest version of patch, includes fullname field, test
> updates, noted in documentation and in NEWS file.
>
> Is this Ok?
The code looks good to me, thanks.
But it looks strange to me that NEWS has more detail on the new output
than the docs. IMO, it would be good if, e.g., something around the
part that reads:
The output for each instruction is composed of four fields:
was updated to reflect the new field. The short examples alone
don't explain what the field is.
In any case, Eli will give you the final word on the docs bits.
Thanks,
--
Pedro Alves