This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix two memory leaks
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, "gdb-patches\ at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Wed, 24 Oct 2012 08:54:59 -0600
- Subject: Re: [RFA] Fix two memory leaks
- References: <50870A74.80903@redhat.com> <20121023220236.GG3555@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> This one looks good to me. But I'm wonderin if we shouldn't also
Joel> document the fact that decode_line_with_current_source returns
Joel> a structure that contains newly allocated memory?
The docs for it should probably reference decode_line_full.
>> * linespec.c (parse_linespec): Do cleanups after
>> parsing a convenience variable.
Joel> This one looks good to me too.
Joel> You might want to wait for a day or two before checking in, as these
Joel> files are not within my area of expertise. But I verified that the
Joel> memory is allocated on the heap, and leaked if not free'ed.
I think they are both ok as well.
Tom