This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix kfail in gdb.base/callfuncs.exp


>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

No comment on the patch, just a question

Yao> -	setup_kfail_for_target gdb/12798 "x86_64-*-*"

I didn't know this proc, so I looked it up:

proc setup_kfail_for_target { PR target } {
    if { [istarget $target] } {
	setup_kfail $PR $target
    }
}

But setup_kfail itself just does:

proc setup_kfail { args } {
[...]
	if {[istarget $sub_arg]} {
	    set kfail_flag 1
	    continue
	}

So I don't understand how setup_kfail_for_target is different.
If I'm missing something, I'd like to know what.
Otherwise I think we can nuke this proc entirely.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]