This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions)


Done,

new patch attached.

Thanks,
	Giuseppe

> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Friday, October 19, 2012 6:56 PM
> To: Giuseppe MONTALTO
> Cc: Eli Zaretskii; tromey@redhat.com; gdb-patches@sourceware.org;
> Hafiz_Abid@mentor.com
> Subject: Re: [PATCH] enhancement of mi_cmd_data_write_memory_bytes
> for filling memory regions (was [PATCH] new MI command for pattern filling
> of memory regions)
> 
> On 10/19/2012 03:11 PM, Giuseppe MONTALTO wrote:
> > +	* gdb.texinfo (-data-write-memory-bytes): Changed the command
> > +	description and added an example to reflect current implementation.
> 
> Don't use past tense:
> 
>  s/Changed/Change/
>  s/added/add/
> 
> The norm is to use the section name as context.  As with the other log entry,
> I'd mention exactly what is being changed to help archaeology/grepping.
> Thus I suggest:
> 
> 	* gdb.texinfo (GDB/MI Data Manipulation): Document new optional
> parameter
> 	"count" of -data-write-memory-bytes, and add an example.
> 
> Thanks.
> 
> --
> Pedro Alves

Attachment: patch-V.11.patch
Description: patch-V.11.patch


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]