This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: fix bug in compare_breakpoints


On 10/19/2012 06:12 PM, Joel Brobecker wrote:
>> A few are just to stick a comment there, and some others are to work
>> around warn_unused_result.
> 
> Yeah. In the first case, we could move the comment back to the top,
> although perhaps it's easier to read an understand the current way.
> I also saw the ones around "warn_unused_result" and we could have
> used a cast to (void), I suppose. 

Last I wrote one of those, a cast to (void) wasn't good enough to silence
the warning.

> But in the end, all of this isn't
> really all that important. Gives us an opportunity to request a comment
> explaining why it's OK to ignore the return value :-).

Indeed.  :-)

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]