This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions)
- From: Pedro Alves <palves at redhat dot com>
- To: Giuseppe MONTALTO <giuseppe dot montalto at st dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, "tromey at redhat dot com" <tromey at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "Hafiz_Abid at mentor dot com" <Hafiz_Abid at mentor dot com>
- Date: Fri, 19 Oct 2012 17:55:51 +0100
- Subject: Re: [PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions)
- References: <76FE3225DF13124EA2D05B290B624C95E65F2D466E@SAFEX1MAIL1.st.com> <87sjf9rzr0.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E65FECE356@SAFEX1MAIL1.st.com> <871umsqgu8.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E65FECE48F@SAFEX1MAIL1.st.com> <87397624b9.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E662A6921F@SAFEX1MAIL1.st.com> <EB3B29AD43CA924DA27099BC851923762992F7@EU-MBX-03.mgc.mentorg.com> <76FE3225DF13124EA2D05B290B624C95E6632A4256@SAFEX1MAIL1.st.com> <878vcc1s9f.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E66B003EA8@SAFEX1MAIL1.st.com> <87wqzgwm4k.fsf@fleche.redhat.com> <76FE3225DF13124EA2D05B290B624C95E66B004AC6@SAFEX1MAIL1.st.com> <50802300.6040304@redhat.com> <76FE3225DF13124EA2D05B290B624C95E66B370299@SAFEX1MAIL1.st.com> <83pq4f1yda.fsf@gnu.org> <76FE3225DF13124EA2D05B290B624C95E66C43ADB1@SAFEX1MAIL1.st.com>
On 10/19/2012 03:11 PM, Giuseppe MONTALTO wrote:
> + * gdb.texinfo (-data-write-memory-bytes): Changed the command
> + description and added an example to reflect current implementation.
Don't use past tense:
s/Changed/Change/
s/added/add/
The norm is to use the section name as context. As with the other log entry, I'd
mention exactly what is being changed to help archaeology/grepping. Thus I suggest:
* gdb.texinfo (GDB/MI Data Manipulation): Document new optional parameter
"count" of -data-write-memory-bytes, and add an example.
Thanks.
--
Pedro Alves