This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix mi "-var-create" regression


Hi Tom,

On 10/17/2012 10:13 PM, Tom Tromey wrote:
"Luis" == Luis Machado<lgustavo@codesourcery.com> writes:

Luis> + && TYPE_CODE (TYPE_TARGET_TYPE (result)) != TYPE_CODE_VOID)


On further reflection, I have a question and a comment.

First, perhaps instead of excluding void* here, we should only allow
pointers to structs.  That is the only case that has RTTI anyhow.  What
do you think?

That sounds reasonable to me.

Also, I think this needs a check_typedef around TYPE_TARGET_TYPE.



Probably. If the target type is deep into a typedef pile, we won't get this right.


I'll have it fixed and will provide that testcase.

Thanks!
Luis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]