This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add skip_shlib_tests guard to tests that require shared lib support


On 10/17/12 16:17, Pedro Alves wrote:
On 10/12/2012 09:57 AM, Yufeng Zhang wrote:

+if {[skip_shlib_tests]} { + untested ctxobj.exp + return -1 +}

See<http://sourceware.org/gdb/wiki/GDBTestcaseCookbook>.


"In untested calls, please spell out the reason the test ends up untested, instead
of just writing the test name, as with the latter we just end up with the test name
duplicated in the gdb.sum output. For example: "

But in these skip_ *cases, I think we can just be silent.  The vast majority of
the skip_* calls in the testsuite agrees (e.g., seen
with 'grep -rn "skip_" -A 3 | grep untested').

IOW, this is OK with the untested calls removed.

Thanks!


I've removed the untested calls; the updated patch has been committed
http://sourceware.org/ml/gdb-cvs/2012-10/msg00077.html.

Thanks,
Yufeng

Attachment: skip-shared-lib-tests.patch.v2
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]