This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Display full file path in MI style disassembly listing


On Thu, 18 Oct 2012 11:34:15 +0200, Andrew Burgess wrote:
> On 17/10/2012 6:15 PM, Tom Tromey wrote:
> >>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
> > It isn't obvious to me that this only applies to the MI case.
> > Can you explain that?
> 
> You are correct, and my subject line is miss-leading.  It is possible to
> hit this code from cli gdb, but I believe this only happens if we fail
> to open the file.

This discussion is difficult without backing the patch with a testcase, at
least for the cases you want to change (cases you do not want to change would
be also nice to check but I understand it may be too broad to cover).

Otherwise the "sleeping" patch I mentioned I would like to push again later
may likely break this new functionality without noticing it.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]