This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFT/RFA/MinGW] remove some extraneous changes in readline/terminal.c


On 10/17/2012 06:06 PM, Joel Brobecker wrote:

> readline/ChangeLog.gdb:
> 
>         * terminal.c: Remove duplicate includes of windows.h and
>         wincon.h.
>         (_rl_get_screen_size): Remove redundant code for MinGW getting
>         the console size from the Windows API.
> 
> Given the small amount of testing, I won't commit unless someone
> reviews this patch and agrees that it is correct.

FWIW, looks obviously correct to me.

Looking at http://sourceware.org/ml/gdb/2011-04/msg00002.html , I didn't
spot any other mingw32 related bits that could be similarly unnecessary.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]