This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH fix start-time and stop-time in trace-status


Hi Tom,
Pedro already asked to rewrite this patch at gdbserver-side and use hex instead of decimal.
See http://sourceware.org/ml/gdb-patches/2012-10/msg00193.html
Could you setup one common opinion about what way is right?
It would very kind of you if you can look at other 2 related patches.


Thank you,
Dmitry

On 10/15/2012 11:11 PM, Tom Tromey wrote:
"Dmitry" == Dmitry Kozlov <dmitry_kozlov@mentor.com> writes:
Dmitry> +2012-10-01  Dmitry Kozlov  <ddk@mentor.com>
Dmitry> +
Dmitry> +	* tracepoint.c (trace_status_command): Fix type of printf arg.
Dmitry> +	(trace_status_mi): Likewise.

Looks pretty good.

Dmitry> + val = strtoulst(++p1, (const char **) &p, 10);

Space before open paren.

Dmitry> + val = strtoulst(++p1, (const char **) &p, 10);

Likewise.

This is ok with these fixed.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]