This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Fix for gdb.parameter('architecture') returning empty string


Siva Chandra <sivachandra@google.com> writes:

> @@ -274,19 +275,13 @@ show_endian (struct ui_file *file, int f
>  	     const char *value)
>  {
>    if (target_byte_order_user == BFD_ENDIAN_UNKNOWN)
> -    if (gdbarch_byte_order (get_current_arch ()) == BFD_ENDIAN_BIG)
>        fprintf_unfiltered (file, _("The target endianness is set automatically "
> -				  "(currently big endian)\n"));
> -    else
> -      fprintf_unfiltered (file, _("The target endianness is set automatically "
> -				  "(currently little endian)\n"));
> +				  "(currently %s endian)\n"),
> +                          endian_string);
>    else
> -    if (target_byte_order_user == BFD_ENDIAN_BIG)
> -      fprintf_unfiltered (file,
> -			  _("The target is assumed to be big endian\n"));
> -    else
>        fprintf_unfiltered (file,
> -			  _("The target is assumed to be little endian\n"));
> +			  _("The target is assumed to be %s endian\n"),
> +                          endian_string);

This is bad for i18n, since big/little can no longer be translated.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]