This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[obv] Call gdb_load_shlibs in solib-{precsave|reverse}.exp.


Hi,
There is a shared lib used in olib-{precsave|reverse}.exp, so
gdb_load_shlibs is needed.  This patch is to call
gdb_load_shlibs.  This fixes some fails in remote testing.

On the other hand, tests olib-{precsave|reverse}.exp
are related to shared lib, so check skip_shlib_test first.

It is obvious to me.  If no other comments in several days, I'll
check it in.

gdb/testsuite:

2012-10-12  Yao Qi  <yao@codesourcery.com>

	* gdb.reverse/solib-precsave.exp: Skip if skip_shlib_test
	returns true.
	Call gdb_load_shlibs.
	* gdb.reverse/solib-reverse.exp: Likewise.
---
 gdb/testsuite/gdb.reverse/solib-precsave.exp |    5 ++++-
 gdb/testsuite/gdb.reverse/solib-reverse.exp  |    5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.reverse/solib-precsave.exp b/gdb/testsuite/gdb.reverse/solib-precsave.exp
index 85384c3..2d493ba 100644
--- a/gdb/testsuite/gdb.reverse/solib-precsave.exp
+++ b/gdb/testsuite/gdb.reverse/solib-precsave.exp
@@ -20,6 +20,9 @@
 if ![supports_process_record] {
     return
 }
+if {[skip_shlib_tests]} {
+    return
+}
 
 standard_testfile solib-reverse.c
 set precsave [standard_output_file solib.precsave]
@@ -59,7 +62,7 @@ gdb_test_no_output "set debug-file-directory"
 
 gdb_reinitialize_dir $srcdir/$subdir
 gdb_load ${binfile}
-
+gdb_load_shlibs $library
 
 runto main
 
diff --git a/gdb/testsuite/gdb.reverse/solib-reverse.exp b/gdb/testsuite/gdb.reverse/solib-reverse.exp
index d878a7f..674dec6 100644
--- a/gdb/testsuite/gdb.reverse/solib-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/solib-reverse.exp
@@ -19,6 +19,9 @@
 if ![supports_reverse] {
     return
 }
+if {[skip_shlib_tests]} {
+    return
+}
 
 standard_testfile
 set libfile  "shr2"
@@ -51,7 +54,7 @@ gdb_test_no_output "set debug-file-directory"
 
 gdb_reinitialize_dir $srcdir/$subdir
 gdb_load ${binfile}
-
+gdb_load_shlibs $library
 
 runto main
 
-- 
1.7.7.6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]