This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC 0/2, gdbserver] Set linux target in async mode in default


On 09/26/2012 12:23 AM, Pedro Alves wrote:
Please explain better why this is necessary (probably with an example).
What exactly doesn't work if you don't do this change?  It sounds as though
this could make gdbserver push notifications down to GDB in all-stop
mode even when it isn't waiting for server replies?

Pedro,
I think about your question and 'async notification' again, looks we have two options on the timing of sending '%' notifications,


1. in server.c:handle_target_event, in which %Stop is sent,
2. in the place where something interesting happens. For example, if we have a notification trace stop, '%Trace' notification is sent at the end of tracepoint.c:stop_tracing.


My original design is to defer *all* notification sent in #1 (handle_target_event), so async mode should be on. Today, I find that notifications except %Stop can be sent in #2, and don't have to put them into #1. If this sounds reasonable to you, this patch set is useless, and I'll revise my 'async notification' patch set in this way.

--
Yao


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]