This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Modify trace-status output to always output stop-notes.


On 10/10/2012 07:17 PM, Dmitry Kozlov wrote:
+  if (ts->stop_desc)
+    {
+	  char *buf = (char *) xmalloc (strlen (ts->stop_desc) * 2 + 1);
+
+	  bin2hex ((gdb_byte *) ts->stop_desc, buf, 0);
+	  fprintf (fp, ";stop-notes:%s", buf);
+   }

Besides Stan's comments, the indentation here looks strange to me, and BUF is not xfree'ed.

--
Yao


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]