This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Modify trace-status output to always output stop-notes.


Hi Abid,
thank you for noting this,
I will repost patch with this change after collecting other's comments.

Regards,
Dmitry

On 10/10/2012 04:40 PM, Abid, Hafiz wrote:
Just a small formatting nit.
+      else if (strncmp (p, "stop-notes", p1 - p) == 0)
+	{
+	  ++p1;
+	  ts->stop_desc= xmalloc (strlen (p) / 2);
A space is missing before =
+	  end = hex2bin (p1, ts->stop_desc, (p3 - p1) / 2);
+	  ts->stop_desc[end] = '\0';
+	  p = p3;
+	}

Regards,
Abid
--
Hafiz Abid Qadeer
Mentor Graphics
hafiz_abid@mentor.com
+44 161 926 1630

-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
owner@sourceware.org] On Behalf Of Kozlov, Dmitry
Sent: Wednesday, October 10, 2012 12:18 PM
To: gdb-patches@sourceware.org; Shebs, Stan
Cc: Prus, Vladimir; Qi, Yao
Subject: [PATCH] Modify trace-status output to always output stop-
notes.

Hi,
accoriding to discussion in gdb mailing list I have added stop-notes as
mandatory part of MI trace-status command. This makes processing of
stop-notes on IDE side more uniform with trace-notes processing.
Previously Yao mentioned that he implemented notifications that can be
used to monitor trace-status, but putting stop-notes to trace-status
looks more clear way because processing one extra trace-status
parameter defferently from others.

Stan, is it ok?

Thank you


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]