This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
PING: [PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions)
- From: Giuseppe MONTALTO <giuseppe dot montalto at st dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "Abid, Hafiz" <Hafiz_Abid at mentor dot com>
- Date: Tue, 9 Oct 2012 16:37:14 +0200
- Subject: PING: [PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions)
Any news?
> -----Original Message-----
> From: Giuseppe MONTALTO
> Sent: Monday, October 01, 2012 11:29 AM
> To: 'Tom Tromey'
> Cc: gdb-patches@sourceware.org; Abid, Hafiz
> Subject: RE: [PATCH] enhancement of mi_cmd_data_write_memory_bytes
> for filling memory regions (was [PATCH] new MI command for pattern filling
> of memory regions)
>
> New patch attached:
> - removed trivial comments
> - removed redundant "else if" clause
>
> Any further feedback is always welcome,
> Giuseppe.
>
> > -----Original Message-----
> > From: Tom Tromey [mailto:tromey@redhat.com]
> > Sent: Friday, September 28, 2012 10:07 PM
> > To: Giuseppe MONTALTO
> > Cc: gdb-patches@sourceware.org; Abid, Hafiz
> > Subject: Re: [PATCH] enhancement of
> mi_cmd_data_write_memory_bytes for
> > filling memory regions (was [PATCH] new MI command for pattern filling
> > of memory regions)
> >
> > >>>>> "Giuseppe" == Giuseppe MONTALTO <giuseppe.montalto@st.com>
> > writes:
> >
> > Giuseppe> the attached patch should fix all the issues.
> >
> > Thanks. Unfortunately I thought of one more little thing.
> >
> > Giuseppe> + remainder = count % len; /* there may be some spare
> bytes.
> > */
> >
> > Comment should start with a capital letter.
> > Though TBH you could also just remove this comment since I think the
> > code is already clear.
> >
> > Giuseppe> + if (remainder > 0) /* copy spare bytes too. */
> >
> > Likewise on both counts.
> >
> > Giuseppe> + else if (len > count)
> > Giuseppe> + {
> > Giuseppe> + /* Pattern is longer than count:
> > Giuseppe> + just copy len bytes. */
> > Giuseppe> + data = xmalloc (len);
> > Giuseppe> + make_cleanup (xfree, data);
> > Giuseppe> + memcpy (data, databuf, len);
> >
> > There's no need to copy the data here.
> > Just set data=databuf.
> >
> > Tom