This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [commit][obv] Use TYPE_LENGTH directly where possible

From: Tom Tromey <tromey at redhat dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, gdb-patches at sourceware dot org
Date: Wed, 26 Sep 2012 09:07:09 -0600
Subject: Re: [commit][obv] Use TYPE_LENGTH directly where possible
References: <20120926132621.5f45acb7@spoyarek> <20120926094227.GA4335@adacore.com> <20120926152740.0900e9b7@spoyarek> <20120926105205.GB4335@adacore.com>

Joel> But I can definitely see someone like myself missing that subtlety,
Joel> and commit an obvious change that reduces the duplication by re-using
Joel> the variable in the gdb_assert call. To the unattentive me, that's
Joel> an obvious improvement. I think that's an issue.

Yeah, that's easy to picture happening.

It seems to me that a comment would be adequate.

Tom

References:
- [commit][obv] Use TYPE_LENGTH directly where possible
  - From: Siddhesh Poyarekar
- Re: [commit][obv] Use TYPE_LENGTH directly where possible
  - From: Joel Brobecker
- Re: [commit][obv] Use TYPE_LENGTH directly where possible
  - From: Siddhesh Poyarekar
- Re: [commit][obv] Use TYPE_LENGTH directly where possible
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]